[virt-tools-list] [PATCH virt-viewer 00/10] Make dialogs use GtkHeaderBar

[Daniel P. Berrange]

On Fri, Feb 17, 2017 at 03:49:47PM -0200, Eduardo Lima (Etrunko) wrote:
> On 16/02/17 20:57, Daniel P. Berrange wrote:
> > On Thu, Feb 16, 2017 at 11:05:13AM -0200, Eduardo Lima (Etrunko) wrote:
> >> On 16/02/17 10:06, Pavel Grunt wrote:
> >>> Hi,
> >>>
> >>> On Thu, 2017-02-09 at 17:22 -0200, Eduardo Lima (Etrunko) wrote:
> >>>> This whole series is the result of the initial idea of having the
> >>>> new
> >>>> iso-dialog to use this widget. Having it done only for the iso-
> >>>> dialog
> >>>> would not make much sense, so I went on and ported all other
> >>>> dialogs.
> >>>> The widget requires Gtk version 3.12, which should not be a problem
> >>>> for
> >>>> any recent distro.
> >>>>
> >>>> Using GtkHeaderBar makes dialogs look cleaner and more 'modern',
> >>>> also
> >>>> follow the style used by GNOME applications. In the near future,
> >>>> virt-viewer main window could also make use of it, as we recently
> >>>> saw in
> >>>> a series sent to this mailing list.
> >>>
> >>> so are we going for the GNOME style for all desktop envs ? In my
> >>> opinion it does not look nice in Windows and Xfce - simply does not
> >>> fit it in. iirc it was mentioned that there is a way to have both the
> >>> classic and the GNOME look in the discussion about Sagar's patches few
> >>> weeks ago..
> >>
> >> I have no idea of what it looks like in Windows, but it indeed looks
> >> good in Linux environments. I tested in both GNOME and Enlightenment,
> >> not sure about other DEs out there. As far as I remember, the discussion
> >> on that other series was about the classic menu versus the buttons on
> >> the header bar.
> > 
> > Please post some screenshots showing the before & after state of this
> > on GNOME, Linux non-GNOME and Windows, so we can accurately evaluate
> > what the change is.
> 
> Okay, I have uploaded the screenshots of the dialogs to the following url:
> 
> http://imgur.com/a/WHt8R
> 
> I ran both before-series and after-series in GNOME and Enlightenment,
> all dialogs look exactly the same, except for the about dialog. By the
> way, I realized I should not mess with the About dialog, it does its own
> magic automatically. That one patch should be dropped.

I'm surprised it looks the same in GNOME + Enlightenment - I guess
Enlightenment must be supporting the same magic GNOME does to allow
GTK to do client side window decorations, without then adding its
own title bar too.  The dual titlebars is my main concern as I think
we saw that in the previous proposal for this kind of change.

I'd particularly like to see what happens in Windows with this change.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|