[virt-tools-list] [virt-manager PATCH v2 3/9] inspection: simplify VMs visit

Richard W.M. Jones rjones at redhat.com
Thu Feb 23 10:53:35 UTC 2017


On Thu, Feb 23, 2017 at 11:22:21AM +0100, Pino Toscano wrote:
> -        obj = ("vm_added")
> +        obj = ("vm_added", conn.get_uri(), connkey)

I wondering if using a dict here makes more sense, so you can retrieve
the fields by name instead of by offset.

The change itself looks reasonable, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the virt-tools-list mailing list