[virt-tools-list] [virt-manager PATCH v2 8/9] details: refresh Information page on inspection data change

Richard W.M. Jones rjones at redhat.com
Thu Feb 23 11:03:25 UTC 2017


On Thu, Feb 23, 2017 at 11:22:26AM +0100, Pino Toscano wrote:
> Refresh the 'Information' page when there are new inspection data
> available, so they can be seen even without switching to a different
> page and back.  This could be seen when starting virt-manager, and
> opening quickly the 'Information' page of an uninspected guest.
> ---
>  virtManager/details.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 0503a44..ca097cc 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -580,6 +580,7 @@ class vmmDetails(vmmGObjectUI):
>          # Deliberately keep all this after signal connection
>          self.vm.connect("state-changed", self.refresh_vm_state)
>          self.vm.connect("resources-sampled", self.refresh_resources)
> +        self.vm.connect("inspection-changed", lambda *x: self.refresh_inspection_page())
>  
>          self.populate_hw_list()

If I'm reading the code correctly, before this commit was the
inspection-changed signal generated but never consumed anywhere?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/




More information about the virt-tools-list mailing list