[virt-tools-list] [PATCH v2] spice: Fix display id in the warning log

[Pavel Grunt]

On Fri, 2016-12-30 at 00:56 +0100, Fabiano Fidêncio wrote:
> Snir,
> 
> Sorry, I didn't pay attention to the bug report while reviewing the
> v1
> and by checking it now, I kinda agree with Pavel that the message
> shouldn't be a warning (but I'd be okay with a debug message).
> 
oh, by my comment
 https://bugzilla.redhat.com/show_bug.cgi?id=1368390#c2 I didn't mean
to change the warning to the debug. I meant that the part of the code
should not be reached at all - ie the race should ideally be fixed.

Pavel

> So, my suggestion, another oneliner patch changing the g_warning()
> to g_debug().
> 
> On Thu, Dec 29, 2016 at 2:40 PM, Snir Sheriber <ssheribe at redhat.com>
> wrote:
> > The display id in the warning log is now consistent with the
> > display
> > id in the "view->displays->display x" menu item
> > 
> > Resolves: rhbz#1368390
> 
> Then, with my suggestion, I'll change this "Resolves" to "Related"
> before pushing, no need to send a v3 of this one.
> 
> > ---
> >  src/virt-viewer-session-spice.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-
> > session-spice.c
> > index 731f074..c24f94d 100644
> > --- a/src/virt-viewer-session-spice.c
> > +++ b/src/virt-viewer-session-spice.c
> > @@ -915,7 +915,7 @@
> > virt_viewer_session_spice_display_monitors(SpiceChannel *channel,
> >          if (!disabled && fullscreen_mode && self->priv-
> > >did_auto_conf &&
> >              !display_is_in_fullscreen_mode(self,
> > VIRT_VIEWER_DISPLAY(display))) {
> >              g_warning("display %d should not be enabled,
> > disabling",
> > -                      virt_viewer_display_get_nth(VIRT_VIEWER_DIS
> > PLAY(display)));
> > +                      virt_viewer_display_get_nth(VIRT_VIEWER_DIS
> > PLAY(display)) + 1);
> >              spice_main_set_display_enabled(virt_viewer_session_sp
> > ice_get_main_channel(self),
> >                                             virt_viewer_display_ge
> > t_nth(VIRT_VIEWER_DISPLAY(display)),
> >                                             FALSE);
> > --
> > 2.9.3
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> Consider this patch ACKed with the suggestions but will just be
> pushed
> when the next patch arrives (lowering the warning to debug)
> 
> Reviewed-by: Fabiano Fidêncio <fabano at fidencio.org>