[virt-tools-list] [PATCH] Update warning msg in virt-viewer's window

[Pavel Grunt]

On Tue, 2016-12-27 at 13:58 +0100, Fabiano Fidêncio wrote:
> On Tue, Dec 27, 2016 at 10:57 AM, Snir Sheriber <ssheribe at redhat.com
> > wrote:
> > Warning "Display can only be attached through libvirt with --
> > attach" is
> > now appears also in virt-viewer's window (as in the cmd prompt)
> > when
> > virt-viewer is waiting without --attach and then the guest starts
> > (instead of showing "Waiting for guest domain to start")
> > 
> > rhbz#1386630
> 
> The idea is good but I here is not the right place to report the
> error..
> I'd say we probably want to do all the error reporting on
> app_activate() instead.

Yes, it is the first step - have virt_viewer_app_activate() setting
the text.

The second step actually resolving the bug rhbz#1386630 would be to
close the app by the dialog in advance (ie `virt-viewer DOMAIN` would
say that --attach is needed even before the DOMAIN is started).

Pavel

> 
> > ---
> >  src/virt-viewer-app.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> > index bf32315..01392f3 100644
> > --- a/src/virt-viewer-app.c
> > +++ b/src/virt-viewer-app.c
> > @@ -1219,6 +1219,7 @@
> > virt_viewer_app_default_activate(VirtViewerApp *self, GError
> > **error)
> >      } else {
> >          g_set_error_literal(error, VIRT_VIEWER_ERROR,
> > VIRT_VIEWER_ERROR_FAILED,
> >                              _("Display can only be attached
> > through libvirt with --attach"));
> > +        virt_viewer_app_show_status(self, _("Display can only be
> > attached through libvirt with --attach"));
> >     }
> > 
> >      return FALSE;
> > --
> > 2.9.3
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> 
>