[virt-tools-list] [PATCH virt-viewer] Do not print credentials in the debug log

Christophe Fergeau cfergeau at redhat.com
Wed Jan 4 09:58:08 UTC 2017


Hey,

On Wed, Jan 04, 2017 at 10:44:22AM +0100, Pavel Grunt wrote:
> Resolves: rhbz#1410030
> ---
>  src/virt-viewer.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index 1121146..4da5cd5 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -936,7 +936,6 @@ virt_viewer_auth_libvirt_credentials(virConnectCredentialPtr cred,
>                  cred[i].resultlen = strlen(cred[i].result);
>              else
>                  cred[i].resultlen = 0;
> -            g_debug("Got '%s' %d %d", cred[i].result, cred[i].resultlen, cred[i].type);

I'd keep the g_debug for AUTHNAME/USERNAME, and have some placeholder for
PASSPHRASE ("Got passphrase XXX %d", cred[i].type))

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170104/ced3e1f5/attachment.sig>


More information about the virt-tools-list mailing list