[virt-tools-list] [virt-manager PATCH] virtinst/cli: set default value for disk sparse to "yes"

Pavel Hrdina phrdina at redhat.com
Tue Jan 17 11:56:01 UTC 2017


Commit 41a84bae9 reworked CLI parsing, but lost the default value disk
sparse option.  Man page also states that the default value is "yes".

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1392990

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Pushed under trivial rule.

 virtinst/cli.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtinst/cli.py b/virtinst/cli.py
index 0bad1c9f..94ba5cbb 100644
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -1929,7 +1929,7 @@ class ParserDisk(VirtCLIParser):
         volname = self.optdict.pop("vol", None)
         size = parse_size(self.optdict.pop("size", None))
         fmt = self.optdict.pop("format", None)
-        sparse = _on_off_convert("sparse", self.optdict.pop("sparse", None))
+        sparse = _on_off_convert("sparse", self.optdict.pop("sparse", "yes"))
         convert_perms(self.optdict.pop("perms", None))
         has_type_volume = ("source_pool" in self.optdict or
                            "source_volume" in self.optdict)
-- 
2.11.0




More information about the virt-tools-list mailing list