[virt-tools-list] [PATCH virt-viewer 01/10] remote-viewer: Extend #ifdef HAVE_OVIRT block

Christophe Fergeau cfergeau at redhat.com
Tue Jan 17 15:51:08 UTC 2017


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote:
> The #endif is closing a #ifdef HAVE_OVIRT block, while another one is
> opened right next, so there is no need to have those lines. Also, due to
> the large amount of source code in between, add a small comment on the
> last #endif to identify what it refers to.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  src/remote-viewer.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/remote-viewer.c b/src/remote-viewer.c
> index 6d29bf2..13c6e7c 100644
> --- a/src/remote-viewer.c
> +++ b/src/remote-viewer.c
> @@ -1005,9 +1005,6 @@ error:
>      return success;
>  }
>  
> -#endif
> -
> -#ifdef HAVE_OVIRT
>  static OvirtVm *
>  choose_vm(GtkWindow *main_window,
>            char **vm_name,
> @@ -1047,7 +1044,7 @@ choose_vm(GtkWindow *main_window,
>  
>      return vm;
>  }
> -#endif
> +#endif /* HAVE_OVIRT */
>  
>  static void
>  remote_viewer_recent_add(gchar *uri, const gchar *mime_type)
> -- 
> 2.9.3
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170117/8a5cf597/attachment.sig>


More information about the virt-tools-list mailing list