[virt-tools-list] [PATCH virt-viewer 07/10] iso-dialog: Implement functionality provided by oVirt foreign menu

[Eduardo Lima (Etrunko)]

On 17/01/17 14:01, Christophe Fergeau wrote:
> On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  src/remote-viewer-iso-list-dialog.c        | 205 ++++++++++++++++++++++++++++-
>>  src/resources/ui/remote-viewer-iso-list.ui |   5 +-
>>  2 files changed, 206 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/remote-viewer-iso-list-dialog.c b/src/remote-viewer-iso-list-dialog.c
>> index 858719c..00371ff 100644
>> --- a/src/remote-viewer-iso-list-dialog.c
>> +++ b/src/remote-viewer-iso-list-dialog.c
>> @@ -20,12 +20,16 @@
>>  
>>  #include <config.h>
>>  
>> +#include <stdlib.h>
> 
> This is added because you call free() in a few places, but why are you
> not using g_free() in these places?

As a matter of consistency, because in ovirt-foreign-menu, we return a
char *, not a gchar *, although I know there is no difference. I can
change that function to return a gchar and then use g_free all around.


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com