[virt-tools-list] [virt-manager] [PATCH v2 3/8] pylint: Redefining name 'os' from outer scope

Cole Robinson crobinso at redhat.com
Mon Jul 10 13:38:55 UTC 2017


I reviewed + pushed this first since it's a good idea even if it isn't
triggering a pylint warning with master yet

Thanks,
Cole

On 07/05/2017 12:51 PM, Radostin Stoyanov wrote:
> ---
>  virtManager/create.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/virtManager/create.py b/virtManager/create.py
> index 20880da..1559a34 100644
> --- a/virtManager/create.py
> +++ b/virtManager/create.py
> @@ -1065,10 +1065,10 @@ class vmmCreate(vmmGObjectUI):
>              # and which do not.
>              variants = virtinst.OSDB.list_os(typename=_type,
>                  sortpref=preferred)
> -            all_distros = set([os.distro for os in variants])
> -            distros = [os for os in all_distros if os in groups]
> +            all_distros = set([_os.distro for _os in variants])
> +            distros = [_os for _os in all_distros if _os in groups]
>              distros.sort()
> -            other_distros = [os for os in all_distros if os not in groups]
> +            other_distros = [_os for _os in all_distros if _os not in groups]
>              parents = dict()
>              if len(distros) > 0:
>                  # We have groups for the OSes, so create them.
> 




More information about the virt-tools-list mailing list