[virt-tools-list] [PATCH virt-viewer] msi: Do not escape '$' for wixl-heat

[Christophe Fergeau]

On Mon, Jul 24, 2017 at 10:10:02AM +0200, Pavel Grunt wrote:
> Hi,
> 
> On Mon, 2017-07-24 at 08:54 +0100, Christophe Fergeau wrote:
> > Hey,
> > 
> > On Fri, Jul 21, 2017 at 07:27:45PM +0200, Pavel Grunt wrote:
> > > wixl-heat does it itself since its commit 9273514c95e343340d18067b4f1
> > > 
> > > otherwise msi generation fails with:
> > > Couldn't find file $/tmp/tmp.1MYrxTLd1U/usr/x86_64-w64-mingw32/sys-
> > > root/mingw/bin/debug-helper.exe
> > 
> > Looks like either the git version, or all msitools releases are going to
> > be broken by this change?
> 
> Yes. All the future releases are going to be broken/fixed [1] (do you know why
> it was escaped?) since that change.
> 
> >  Should we do something conditional on wixl
> > --version output? (wixl-heat does not have --version).
> 
> imo overkill. The msi release always happen using the latest released fedora.
> And due to changes in rpms, you need the updated version of msitools anyway...

Well, at the moment this change is not in a release, the .spec file
BuildRequires were not changed to reflect that, ... If we already need a
very new msitools version, I'd mention this in the commit log so that
it's clear this should not cause too much breakage.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170724/76e1f9f8/attachment.sig>