[virt-tools-list] [virt-manager PATCH] pylint: disable undefined-loop-variable

Cole Robinson crobinso at redhat.com
Fri Jun 16 17:14:03 UTC 2017


On 06/14/2017 10:17 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at gmail.com>
> 
>   pylint brings noise, disable it.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
> ---
>  virtinst/urlfetcher.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virtinst/urlfetcher.py b/virtinst/urlfetcher.py
> index 4abc83a..b5b1244 100644
> --- a/virtinst/urlfetcher.py
> +++ b/virtinst/urlfetcher.py
> @@ -500,6 +500,7 @@ def getDistroStore(guest, fetcher):
>                  found = True
>                  break
>  
> +        # pylint: disable=undefined-loop-variable
>          if found:
>              logging.debug("Prioritizing distro store=%s", store)
>              stores.remove(store)
> 

Thanks for the patch, but I fixed this in a different way (changed the way the
loop works), along with fixing a bunch more pylint warnings with latest pylint

- Cole




More information about the virt-tools-list mailing list