[virt-tools-list] [virt-manager] [PATCH 0/9] Integration of virt-bootstrap

[Radostin]

Hi Cole,

Thank you for the feedback.

To solve the problem with virt-bootstrap/skopeo use:

virt-bootstrap docker://fedora /tmp/foo

----------------------^
(docker:// with two slashes)

On 23/06/17 19:43, Cole Robinson wrote:
> On 06/23/2017 01:20 PM, Cole Robinson wrote:
>> On 06/22/2017 10:53 AM, Radostin Stoyanov wrote:
>>> Hi all,
>>>
>>>
>>> These series of patches aim to integrate virt-bootstrap with virt-manager.
>>> The goal is to replace the current message:
>>>
>>> "The OS directory tree must already exist. Creating an OS directory tree
>>> is not yet supported"
>>>
>>> with functionality which allows the user to easy bootstrap root file system
>>> from container image.
>>>
>>> I would like to ask for feedback/suggestions on what could be improved.
>>>
>>> This is a short screen recording which demonstrates these changes:
>>> https://www.youtube.com/watch?v=-OlazoOSKYo
>> Pretty cool!
>>
>> I'm going to do a first pass through the patches and just point out some code
>> stuff, then I'll actually play with it a bit and give some functional comments
>>
> Can't functional test it since virt-bootstrap/skopeo is failing for me. See
> the error below.
>
> A couple functional ideas though:
>
> - If user is going to create a container, we should auto-generate a path for
> them to use (if the path field is empty). This can come later though and
> doesn't need to be mixed in with this round of changes
>
> - I think we should move the actual virt-bootstrap creation to the end of the
> dialog, with the current 'finish' dialog. Depending on how invasive that is it
> could be additive as well, so it doesn't distract from reviewing the new
> functionality.
>
> Thanks,
> Cole
>
>
> $ virt-bootstrap --debug docker:///fedora /tmp/foo
> DEBUG:root:Command: skopeo copy docker:///fedora
> dir:/home/crobinso/.local/share/virt-bootstrap/docker_images
> DEBUG:root:Stderr: time="2017-06-23T14:36:16-04:00" level=fatal msg="Invalid
> source name docker:///fedora: invalid reference format"
>
> ERROR:root:Exit with non-zero code. 1
> Traceback (most recent call last):
>   File
> "/home/crobinso/src/virt-bootstrap/src/virtBootstrap/virt_bootstrap.py", line
> 163, in <module>
>     sys.exit(main())
>   File
> "/home/crobinso/src/virt-bootstrap/src/virtBootstrap/virt_bootstrap.py", line
> 151, in main
>     bootstrap(args)
>   File
> "/home/crobinso/src/virt-bootstrap/src/virtBootstrap/virt_bootstrap.py", line
> 100, in bootstrap
>     source.unpack(args.dest)
>   File "/home/crobinso/src/virt-bootstrap/src/virtBootstrap/sources.py", line
> 289, in unpack
>     execute(skopeo_copy)
>   File "/home/crobinso/src/virt-bootstrap/src/virtBootstrap/sources.py", line
> 73, in execute
>     raise CalledProcessError
> TypeError: __init__() takes at least 3 arguments (1 given)
>
>