[virt-tools-list] [PATCH v3 6/6] Add tests for Virtuozzo hypervisor

Cole Robinson crobinso at redhat.com
Wed Mar 1 20:45:52 UTC 2017


On 02/21/2017 09:28 AM, Mikhail Feoktistov wrote:
> UI and CLI tests
> ---
>  tests/capabilities-xml/vz.xml                      | 53 ++++++++++++++++++++++
>  .../compare/virt-install-vz-ct-template.xml        | 26 +++++++++++
>  tests/clitest.py                                   | 15 ++++++
>  tests/uitests/newvm.py                             | 23 ++++++++++
>  tests/utils.py                                     |  1 +
>  virtinst/uri.py                                    |  4 +-

I pushed this patch with a couple changes.

- Removed the uitests/ bit. That should go in in the same patch as the UI changes

- I had to adjust the test output. Mine had these differences:

diff --git a/tests/cli-test-xml/compare/virt-install-vz-ct-template.xml
b/tests/cli-test-xml/compare/virt-install-vz-ct-template.xml
index 06fdc88..e9e4b05 100644
--- a/tests/cli-test-xml/compare/virt-install-vz-ct-template.xml
+++ b/tests/cli-test-xml/compare/virt-install-vz-ct-template.xml
@@ -8,10 +8,11 @@
     <type arch="x86_64">exe</type>
     <init>/sbin/init</init>
   </os>
-  <on_poweroff>destroy</on_poweroff>
-  <on_reboot>restart</on_reboot>
-  <on_crash>destroy</on_crash>
+  <features>
+    <privnet/>
+  </features>
   <devices>
+    <emulator>vz</emulator>
     <filesystem type="template">
       <source name="centos-7-x86_64"/>
       <target dir="/"/>
@@ -20,7 +21,6 @@
       <source network="Bridged"/>
       <mac address="00:11:22:33:44:55"/>
     </interface>
-    <graphics type="vnc" port="-1" keymap="en-us"/>
     <console type="pty"/>
   </devices>
 </domain>


Ignore the on_* bits, that's from my previous patch. But are the other changes
expected? privnet might be lxc specific, which needs a virtinst change. I
don't know about the other bits though. If they should be changed please send
a follow up patch

Thanks,
Cole




More information about the virt-tools-list mailing list