[virt-tools-list] [virt-manager PATCH] network: add support to create SR-IOV VFs pool

Cole Robinson crobinso at redhat.com
Fri Mar 17 17:10:47 UTC 2017


On 03/17/2017 04:02 AM, Lin Ma wrote:
> Create a network with a device pool containing all the VFs of an SR-IOV
> device.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  ui/createnet.ui          |  92 +++++++++++++++++++++++++++++++++-
>  virtManager/createnet.py | 127 +++++++++++++++++++++++++++++------------------
>  virtinst/network.py      |  12 +++++
>  3 files changed, 182 insertions(+), 49 deletions(-)

This breaks the test suite, you'll need to extend the network-* test in
tests/xmlparse.py

"""
Second list contains 2 additional elements.
First extra element 0:
<XMLProperty ./@dev 140596782899032>

- []
+ [<XMLProperty ./@dev 140596782899032>,
+  <XMLProperty ./@managed 140596782936352>]


This means that there are XML properties that are
untested in the test suite. This could be caused
by a previous test suite failure, or if you added
a new property and didn't extend the test suite.
Look into extending clitest.py and/or xmlparse.py.
"""

I don't know much about this feature. Can you provide an example <network>
definition that we can add to tests/testdriver.xml?

Also, is the XML meant to only use an SR-IOV host device? If so, is that
something we can detect from nodedev XML? Right now looks like your patch
shows all host devices regardless of whether they are SR-IOV enabled

Thanks,
Cole




More information about the virt-tools-list mailing list