[virt-tools-list] [virt-manager PATCH] graphics: skip authentication only for VNC with listen type none

[Pavel Hrdina]

On Thu, Mar 23, 2017 at 10:34:04AM -0400, Cole Robinson wrote:
> On 03/23/2017 10:28 AM, Pavel Hrdina wrote:
> > This is in fact a bug in QEMU so we have to workaround this issue
> > to allow to connect to guest with VNC and listen type none.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1434551
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> 
> ACK
> 
> Just curious, is there a bug report for the qemu issue?

No yet, I'll create a one to track the issue.

Thanks, I'll push it shortly.

Pavel

> 
> - Cole
> 
> > ---
> >  virtManager/domain.py | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
> > 
> > diff --git a/virtManager/domain.py b/virtManager/domain.py
> > index 3478cc58..fc5f54a6 100644
> > --- a/virtManager/domain.py
> > +++ b/virtManager/domain.py
> > @@ -1190,8 +1190,17 @@ class vmmDomain(vmmLibvirtObject):
> >          return self._backend.openConsole(devname, stream, flags)
> >  
> >      def open_graphics_fd(self):
> > -        return self._backend.openGraphicsFD(0,
> > -                libvirt.VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH)
> > +        flags = 0
> > +
> > +        # Ugly workaround for VNC bug where the display cannot be opened
> > +        # if the listen type is "none".  When this gets fixed in QEMU
> > +        # we should skip auth only for broken QEMUs.
> > +        graphics = self.get_graphics_devices()[0]
> > +        if (graphics.type == "vnc" and
> > +            graphics.get_first_listen_type() == "none"):
> > +            flags = libvirt.VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH
> > +
> > +        return self._backend.openGraphicsFD(0, flags)
> >  
> >      def refresh_snapshots(self):
> >          self._snapshot_list = None
> > 
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170323/72a0bcd3/attachment.sig>