[virt-tools-list] [virt-manager PATCH] nodedev: remove useless exception instance

Chen Hanxiao chen_han_xiao at 126.com
Thu Mar 30 14:45:02 UTC 2017



At 2017-03-30 22:12:34, "Cole Robinson" <crobinso at redhat.com> wrote:
>On 03/30/2017 06:20 AM, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at gmail.com>
>> 
>> Commit f341352cdadeadedab1579d1759ed1387aa28c75
>> removed redundant error string,
>> so the instance 'e' in exception is useless.
>> Just delete it.
>> 
>> Signed-off-by: Chen Hanxiao <chenhanxiao at gmail.com>
>> ---
>>  virtinst/nodedev.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/virtinst/nodedev.py b/virtinst/nodedev.py
>> index f82ba35..c8f5adc 100644
>> --- a/virtinst/nodedev.py
>> +++ b/virtinst/nodedev.py
>> @@ -84,7 +84,7 @@ class NodeDevice(XMLBuilder):
>>  
>>          try:
>>              return _AddressStringToNodedev(conn, idstring)
>> -        except Exception, e:
>> +        except Exception:
>>              logging.debug("Error looking up nodedev from idstring=%s",
>>                  idstring, exc_info=True)
>>              raise
>> 
>
>ACK
>

Pushed.

Regards,
- Chen




More information about the virt-tools-list mailing list