[virt-tools-list] [virt-manager PATCH 0/3] add support for memory device

Cole Robinson crobinso at redhat.com
Fri May 5 15:32:43 UTC 2017


On 05/05/2017 06:22 AM, Pavel Hrdina wrote:
> Pavel Hrdina (3):
>   virtinst.cpu: don't validate "cpus" for NUMA cells
>   virtinst: introduce support for <maxMemory> element
>   virtinst: add support for memory device
> 
>  man/virt-install.pod                               | 14 +++++-
>  man/virt-xml.pod                                   |  2 +
>  .../compare/virt-install-memory-device-dimm.xml    | 53 ++++++++++++++++++++
>  .../compare/virt-install-memory-device-nvdimm.xml  | 55 ++++++++++++++++++++
>  .../compare/virt-install-memory-hotplug.xml        | 43 ++++++++++++++++
>  tests/clitest.py                                   |  9 ++++
>  virtinst/cli.py                                    | 42 ++++++++++++++--
>  virtinst/cpu.py                                    |  6 +--
>  virtinst/device.py                                 |  4 +-
>  virtinst/devicememory.py                           | 58 ++++++++++++++++++++++
>  virtinst/guest.py                                  |  8 +--
>  11 files changed, 280 insertions(+), 14 deletions(-)
>  create mode 100644 tests/cli-test-xml/compare/virt-install-memory-device-dimm.xml
>  create mode 100644 tests/cli-test-xml/compare/virt-install-memory-device-nvdimm.xml
>  create mode 100644 tests/cli-test-xml/compare/virt-install-memory-hotplug.xml
>  create mode 100644 virtinst/devicememory.py
> 

ACK, the cli naming collisions are unfortunate but I can't think of a better
solution

Thanks,
Cole




More information about the virt-tools-list mailing list