[virt-tools-list] [virt-manager PATCH 1/2] virtinst: add support enable setting multifunction on hostdev

[Chen Hanxiao]

At 2017-05-10 16:33:48, "Pavel Hrdina" <phrdina at redhat.com> wrote:
>On Tue, May 09, 2017 at 06:23:56PM +0800, Chen Hanxiao wrote:
>> From: Chen Hanxiao <chenhanxiao at gmail.com>
>> 
>>   This patch will enable setting multifunction
>>   on hostdev.
>> 
>
>This patch adds the "multifunction" for the hostdev
>  <source>
>    <address/>
>  </source>
>which is irrelevant.
>
>What you actually need is to set the "multifunction" for the address
>presented to the guest and that is already supported by virt-install.
>
>The test line "--hostdev ..." uses the address.multifunction and not
>the introduced hostdev.multifunction.
>
>This patch isn't needed so NACK.

Ahh, thanks for the review.
I'll post the UI part as v2 soon.

Regards,
- Chen