[virt-tools-list] [virt-manager PATCH] interface: don't print error for active interface without an IP address
Chen Hanxiao
chen_han_xiao at 126.com
Wed May 10 09:44:53 UTC 2017
At 2017-05-10 16:21:43, "Pavel Hrdina" <phrdina at redhat.com> wrote:
>If there is no IP address for active interface we need to skip
>probing it.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1449509
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> virtManager/interface.py | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/virtManager/interface.py b/virtManager/interface.py
>index 2fe61b2a..ce1c1eba 100644
>--- a/virtManager/interface.py
>+++ b/virtManager/interface.py
>@@ -138,13 +138,14 @@ class vmmInterface(vmmLibvirtObject):
> return None, []
>
> ret = []
>- for ip in activeProto.ips:
>- ipstr = ip.address
>- if not ipstr:
>- continue
>- if ip.prefix:
>- ipstr += "/%s" % ip.prefix
>- ret.append(ipstr)
>+ if activeProto:
>+ for ip in activeProto.ips:
>+ ipstr = ip.address
>+ if not ipstr:
>+ continue
>+ if ip.prefix:
>+ ipstr += "/%s" % ip.prefix
>+ ret.append(ipstr)
> return inactiveProto or activeProto, ret
>
> def get_ipv4(self):
>--
ACK.
Regards,
- Chen
More information about the virt-tools-list
mailing list