[virt-tools-list] [PATCH] Remove redundant call of strip()

Cole Robinson crobinso at redhat.com
Wed May 17 16:31:21 UTC 2017


On 05/17/2017 07:53 AM, Radostin Stoyanov wrote:
> Remove redundant call of the strip() function. It is already done in lines 1302 and 1303.
> 
> https://github.com/virt-manager/virt-manager/blob/master/virtManager/create.py#L1302
> https://github.com/virt-manager/virt-manager/blob/master/virtManager/create.py#L1303
> 
> ---
>  virtManager/create.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtManager/create.py b/virtManager/create.py
> index 90d1f787..275b6f39 100644
> --- a/virtManager/create.py
> +++ b/virtManager/create.py
> @@ -1305,7 +1305,7 @@ class vmmCreate(vmmGObjectUI):
>          if media and store_media:
>              self.config.add_media_url(media)
>  
> -        return (media.strip(), extra.strip())
> +        return (media, extra)
>  
>      def _get_config_import_path(self):
>          return self.widget("install-import-entry").get_text()
> 

ACK and pushed, thanks!

Though run this in your virt-manager git repo so that patch subject contains
'virt-manager' since multiple projects use this list

git config format.subjectprefix "PATCH virt-manager"

Thanks,
Cole




More information about the virt-tools-list mailing list