[virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been cancelled

[Xiaodai Wang]

----- Original Message -----
> From: "Victor Toso" <lists at victortoso.com>
> To: "Eduardo Lima (Etrunko)" <etrunko at redhat.com>
> Cc: virt-tools-list at redhat.com
> Sent: Saturday, May 20, 2017 5:26:29 AM
> Subject: Re: [virt-tools-list] [PATCH virt-viewer 2/2] Quit application if in kiosk mode and authentication has been
> cancelled
> 
> Hi,
> 
> On Fri, May 19, 2017 at 05:16:53PM -0300, Eduardo Lima (Etrunko) wrote:
> > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
> >
> > Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> 
> I'm not 100% sure that this would be the desirable behavior. If one runs
> the app in -k, isn't it the point that the user would not have access to
> the desktop?
> 
> AFAICT, the available options are:
> 
> 1) Click cancel, close virt-viewer (this patch)
> 2) Click cancel, open dialog again (your suggestion on bz#1446161)
> 3) Remove cancel button as (2) shows that it is useless

       -k, --kiosk
       Start in kiosk mode. In this mode, the application will start in fullscreen with minimal UI. 
       It will prevent the user from quitting or performing any interaction outside of usage of the remote desktop session.

>From the man page of virt-viewer, i think 2) or 3) is better than 1). 

> 
> Patch works fine so, just to be sure of desirable behavior.
> 
> Cheers,
> 
> > ---
> >  src/virt-viewer-app.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> > index f0fcf21..1975af0 100644
> > --- a/src/virt-viewer-app.c
> > +++ b/src/virt-viewer-app.c
> > @@ -1441,6 +1441,8 @@ virt_viewer_app_disconnected(VirtViewerSession
> > *session G_GNUC_UNUSED, const gch
> >
> >      if (!priv->kiosk)
> >          virt_viewer_app_hide_all_windows(self);
> > +    else if (priv->cancelled)
> > +        priv->quitting = TRUE;
> >
> >      if (priv->quitting)
> >          g_application_quit(G_APPLICATION(self));
> > --
> > 2.9.4
> >
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list