[virt-tools-list] [virt-manager PATCH 3/8] GtkAlignment:xalign

[Pavel Hrdina]

On Sun, May 28, 2017 at 05:55:21PM +0100, Radostin Stoyanov wrote:
> GtkAlignment:xalign was deprecated since Gtk version 3.14 and should not be used in newly-written code.
> 
> Use halign property instead. The default value is set to GTK_ALIGN_FILL.
> 
> https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--xalign
> https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--halign

This was the problematic too large patch and I can see why.  I would
recommend to split this patch into 2 parts:

    "Use halign property instead of xalign"
    "Remove redundant xalign property"

The reason for this is that it would be easier to review and to spot
some missed replacements.  Some of the removed "xalign" properties
are not replaced by halign because the halign property is already there
or is not required.

You can go even further and split the first suggested commit into 2
different commits where one would change '0' to 'start' end the second
would change '1' to 'end'.  The same can be done for the second commit,
where one would just remove xalign='0.5' because the behavior is
identical to the default value of halign and the second patch would
remove the redundant xalign='0|1' where halign is also used.

> ---
>  ui/addhardware.ui     |  84 +++++++-------
>  ui/addstorage.ui      |   8 +-
>  ui/asyncjob.ui        |   6 +-
>  ui/choosecd.ui        |   6 +-
>  ui/clone.ui           |  50 ++++-----
>  ui/connect.ui         |  18 ++-
>  ui/create.ui          | 125 ++++++++++-----------
>  ui/createinterface.ui |  83 +++++++-------
>  ui/createnet.ui       |  85 +++++++--------
>  ui/createpool.ui      |  30 +++--
>  ui/createvol.ui       |  18 +--
>  ui/delete.ui          |   4 +-
>  ui/details.ui         | 296 +++++++++++++++++++++++++-------------------------
>  ui/fsdetails.ui       |  31 +++---
>  ui/gfxdetails.ui      |  30 ++---
>  ui/host.ui            | 115 ++++++++++----------
>  ui/migrate.ui         |  38 +++----
>  ui/netlist.ui         |  17 ++-
>  ui/preferences.ui     |  67 +++++-------
>  ui/snapshots.ui       |  34 +++---
>  ui/storagelist.ui     |  20 ++--
>  21 files changed, 561 insertions(+), 604 deletions(-)
> 
> diff --git a/ui/addhardware.ui b/ui/addhardware.ui
> index 2cd3f20..80be23a 100644
> --- a/ui/addhardware.ui
> +++ b/ui/addhardware.ui
> @@ -81,12 +81,12 @@
>                        <object class="GtkLabel" id="page-title-label">
>                          <property name="visible">True</property>
>                          <property name="can_focus">False</property>
> +                        <property name="halign">start</property>
>                          <property name="xpad">6</property>
>                          <property name="ypad">6</property>
>                          <property name="label">Page title</property>
>                          <property name="use_markup">True</property>
>                          <property name="justify">fill</property>
> -                        <property name="xalign">0</property>
>                          <property name="yalign">0</property>
>                        </object>
>                      </child>

This would be in commit "Use halign property instead of xalign",


> @@ -161,7 +161,6 @@
>                                      <property name="label" translatable="yes">_Device type:</property>
>                                      <property name="use_underline">True</property>
>                                      <property name="mnemonic_widget">storage-devtype</property>
> -                                    <property name="xalign">0</property>
>                                    </object>
>                                    <packing>
>                                      <property name="left_attach">0</property>

and this would be in commit "Remove redundant xalign property".

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170530/e0489b9b/attachment.sig>