[virt-tools-list] [virt-manager PATCHv2 00/13] Drop Gtk deprecation

[Cole Robinson]

On 05/31/2017 09:08 AM, Radostin Stoyanov wrote:
> This is revised version of the patch which aims to resolve Gtk deprecations in the UI files. Glade version 3.20 was used for validation.
> 
> Commits (13):
>   Format UI files with Glade 3.20
>   Use GtkButtonBox instead of GtkHButtonBox
>   Replace xalign='0' with halign='start'
>   Replace xalign='1' with halign='end'
>   Remove redundant xalign property
>   Use valign property instead of yalign
>   Remove deprecated GtkMisc:xpad property
>   Remove deprecated GtkMisc:ypad property
>   Fix typo in Pre-requisite software
>   Convert GtkTable to GtkGrid
>   Remove deprecated GtkActivatable:use-action-appearance property
>   Use GtkSeparator instead of GtkHSeparator
>   Use GtkPaned instead of GtkHPaned
> 
>  INSTALL.md            |   2 +-
>  ui/about.ui           |   2 +-
>  ui/addhardware.ui     | 201 ++++++++----------
>  ui/addstorage.ui      |  17 +-
>  ui/asyncjob.ui        |  29 +--
>  ui/choosecd.ui        |  45 ++--
>  ui/clone.ui           | 236 +++++++++------------
>  ui/connect.ui         |  28 ++-
>  ui/create.ui          | 337 +++++++++++++-----------------
>  ui/createinterface.ui | 326 +++++++++++------------------
>  ui/createnet.ui       | 134 ++++++------
>  ui/createpool.ui      |  43 ++--
>  ui/createvol.ui       |  34 ++-
>  ui/delete.ui          |  10 +-
>  ui/details.ui         | 557 +++++++++++++++++++++++---------------------------
>  ui/fsdetails.ui       |  39 ++--
>  ui/gfxdetails.ui      |  33 ++-
>  ui/host.ui            | 257 ++++++++++-------------
>  ui/manager.ui         |   6 +-
>  ui/migrate.ui         |  47 +++--
>  ui/netlist.ui         |  81 +++-----
>  ui/preferences.ui     |  74 +++----
>  ui/snapshots.ui       |  44 ++--
>  ui/storagebrowse.ui   |   2 +-
>  ui/storagelist.ui     |  31 ++-
>  25 files changed, 1119 insertions(+), 1496 deletions(-)
> 

Nice work! I've pushed your patches now, but I found a few minor issues as well.

- New VM wizard: the label showing the connection URI is weirdly centered.
This worked with gtktable but not gtkgrid. Seems to be some odd interaction
between defining a min/max label size and text justification. I think it's
https://bugzilla.gnome.org/show_bug.cgi?id=733981  but we need to maintain
compat with gtk 3.14, so maybe add a check for gtk >= 3.16 and if so call
set_xalign(0) in create.py. See the Gtk.check_version function usage in
'virt-manager' as an example

- New VM wizard: the memory/cpu table is weirdly centered. I think this is
some weird interaction with the gtkalignment it's using. Since gtkalignment is
deprecated, I think this can be fixed by dropping it for this case, converting
to margin-left, and tweaking the pack settings

- New VM wizard: connect to lxc:///, operating system, just enter /tmp,
forward to the last page and the /tmp label is centered, it should be right
aligned. I didn't look closely but maybe another case of the first issue

- Similar centering issue with File->Open Connection URI field

- Clone wizard network dialog MAC address alignment is wrong. And there's a
few alignment issues in the clone storage subdialog too. If you don't have a
qemu VM for cloning you can use the test driver to play with the UI with
virt-manager --connect test://path/to/virt-manager.git/tests/testdriver.xml

Thanks,
Cole