[virt-tools-list] [virt-manager PATCH 2/7] details: Show controller description + index

[Cole Robinson]

On 11/06/2017 07:52 AM, Lin Ma wrote:
> This patch and future patches can help users to better recognize which
> disks connect to which scsi controllers.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  virtManager/details.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 0923f4b0..22e0786e 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -234,7 +234,7 @@ def _label_for_device(dev):
>      if devtype == "filesystem":
>          return _("Filesystem %s") % dev.target[:8]
>      if devtype == "controller":
> -        return _("Controller %s") % dev.pretty_desc()
> +        return _("Controller %s %s") % (dev.pretty_desc(), dev.index)
>      if devtype == "rng":
>          label = _("RNG")
>          if dev.device:
> 

ACK and will push, though I might push a follow up patch to only add the
index if there's more than one controller of a given type. Maybe do the
same for disks too

Thanks,
Cole