[virt-tools-list] 答复： Re: [virt-manager PATCH 7/7] scsi: Add controller index option and virtio-scsi bus option

[Lin Ma]

>>> Cole Robinson <crobinso at redhat.com> 2017/11/23 星期四 上午 6:23 >>>
>On 11/06/2017 07:52 AM, Lin Ma wrote:
>> When we change disk bus to 'scsi' or add scsi disks, virt-manager relies
>> on libvirt's rules to create addresses. Sometimes it works, sometimes not,
>> Espectially in multiple scsi controllers case, we can not exactly control
>> which virtual disks attach to which scsi controller, sometimes libvirt
>> creates unnecessary scsi controllers for us, attach virtual disks to the
>> scsi controllers which we don't want. It has confused users for a while.
>> 
>> This patch added two new option to solve the above issue:
>> 1. add virtio-scsi bus option. users can decide which kind of scsi bus
>> they want to use, instead of guessing through libvirt.
>> 2. add controller index option. when users configure disk bus, it allows
>> users to exactly choice which existed scsi controller they want to attach
>> or create a new one.
>> 
>> The patch changed some mechanism about adding/configuring scsi bus, and
>> generating device addrStr instead of libvirt did, it avoids some annoying
>> issues.
>> 
>
>There's a lot going on here, this needs to be split into multiple
>patches. At the very least: addhardware controller change, details
>controller change, details virtio-scsi change, but probably some smaller
>patches too
>
>Can you describe more what use case you are trying to facilitate better
>here with the controller indexing changes? Better handling 8+ scsi
>devices? Or just a simple 'I want to use virtio-scsi' use case. Before
>adding more UI complexity I want to be sure this isn't something we can
>mostly fix by having virt-manager be smarter by default
The intention of this patch is allow users to do fine grained control while
they configure virtual scsi disks in multiple virtual scsi controllers case.
 
Before this patch, Users can't control which virtual scsi hba they want the
disks connect to. Libvirt supports the address information, But Virt-manager
doesn't fully use them. It has no idea about any details, It only generates
target device name, Then completely relies on the rules of libvirt to create
device addresses.
After this patch, Users can exactly control which virtual scsi hba they want
to use.
 
Basically, This patch includes 2 changes:
1. add option for specifically for virtio-scsi.
2. add controller index option for fine grained control.
 
First, I want to be sure these changes are acceptable.
Then I'll modify the patch follow your suggestions.
 
Thanks for your review,
Lin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20171127/f96dc5e3/attachment.htm>