[virt-tools-list] [virt-manager PATCH 0/5] improve panic device code

Cole Robinson crobinso at redhat.com
Fri Sep 8 20:00:05 UTC 2017


On 09/05/2017 03:59 AM, Pavel Hrdina wrote:
> Apart from the patches there is one more improvement that could by done.
> For --panic default we could generate an empty XML element <panic/>
> which is accepted by libvirt and libvirt fills in the default values.
> However, I was not able to achieve that because for some reason the
> xmlbuilder ignored the empty element.
> 

Yeah that will need an xmlbuilder extension I think

> Pavel Hrdina (5):
>   virtinst: remove address configuration from panic device
>   virtManager: remove panic iobase from GUI
>   devicepanic: use model instead of address.type
>   devicepanic: don't set default iobase
>   devicepanic: add all models supported by libvirt
> 

Looks good to me, ACK

Thanks,
Cole




More information about the virt-tools-list mailing list