[virt-tools-list] [virt-manager PATCH] choosecd: change order of check operations

Cole Robinson crobinso at redhat.com
Tue Sep 19 23:23:26 UTC 2017


On 09/19/2017 10:18 AM, Pavel Hrdina wrote:
> The current order of check operations is wrong.  First we set the new
> path for the disk in question and after that we check whether some
> guest already uses a disk with the same path.
> 
> The issue is that virt-manager returns a cached list of guests in
> path_in_use_by() and the cached guest has the disk path already
> updated.
> 
> Ideally we don't update the path at all, but we do it to run some
> checks before the path is actually changed.  In order to fix the
> referenced bug, change the order of check operations.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1453094
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

ACK

Thanks,
Cole




More information about the virt-tools-list mailing list