[virt-tools-list] [virt-manager PATCH v2 0/4] Default to libosinfo recommended resources

Fabiano Fidêncio fidencio at redhat.com
Mon Dec 10 09:36:13 UTC 2018


Whenever virt-install is called without pssing --disk or --memory, let's
fallback to libosinfo's recommended resources instead (when those are
available) instead of erroring out.

NOTE: There's no tests written for these changes. So, Cole/Pavel,
please, I'll need a little bit of your time to discuss how to adapt the
current tests in order to test those features considering that a bunch
of tests are not passing the "--memory"  and virt-manager's test suite
just defaults to 64 MB.

- Changes since v1:
  https://www.redhat.com/archives/virt-tools-list/2018-December/msg00006.html
  - Addressed Pavel's comments and fixed the tests that I broke

Fabiano Fidêncio (4):
  guest: Default to libosinfo recommended resources
  tests: Adjust vcpu number
  virt-install: Default to libosnfo recommended disk size
  tests: Adjust single-config-2 test

 .../compare/virt-install-aarch64-kvm-import.xml  |  2 +-
 .../compare/virt-install-arm-kvm-import.xml      |  2 +-
 .../compare/virt-install-f21-kvm-remote.xml      |  2 +-
 .../virt-install-kvm-session-defaults.xml        |  4 ++--
 .../compare/virt-install-kvm-win10.xml           |  4 ++--
 .../compare/virt-install-ppc64le-kvm-import.xml  |  2 +-
 .../compare/virt-install-qemu-32-on-64.xml       |  2 +-
 .../compare/virt-install-s390x-cdrom-KVMIBM.xml  |  2 +-
 .../compare/virt-install-s390x-cdrom.xml         |  2 +-
 .../compare/virt-install-singleton-config-2.xml  | 11 +++++++++++
 .../compare/virt-install-win7-uefi.xml           |  4 ++--
 virt-install                                     | 16 ++++++++++------
 virtinst/guest.py                                | 13 +++++++++++--
 13 files changed, 45 insertions(+), 21 deletions(-)

-- 
2.19.1




More information about the virt-tools-list mailing list