[virt-tools-list] [PATCH v2 10/16] display: allow display without associated monitor number

[Marc-André Lureau]

Hi
On Thu, Dec 20, 2018 at 8:45 PM Victor Toso <victortoso at redhat.com> wrote:
>
> Hi,
>
> On Wed, Sep 26, 2018 at 07:26:33PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > The VTE display will have monitor id -1.
> >
> > Eventually, having a base "console" class without monitor id could
> > avoid this allowance.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  src/virt-viewer-display.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/virt-viewer-display.c b/src/virt-viewer-display.c
> > index a1fcb82..98d4edd 100644
> > --- a/src/virt-viewer-display.c
> > +++ b/src/virt-viewer-display.c
> > @@ -129,7 +129,7 @@ virt_viewer_display_class_init(VirtViewerDisplayClass *class)
> >                                      g_param_spec_int("nth-display",
> >                                                       "Nth display",
> >                                                       "Nth display",
> > -                                                     0,
> > +                                                     -1,
>
> I have a feeling that this should be commited before the vte
> introduction?
>

that doesn't make a big difference, since there is no instance created yet.

> Acked-by: Victor Toso <victortoso at redhat.com>

thanks

>
> >                                                       G_MAXINT32,
> >                                                       0,
> >                                                       G_PARAM_READWRITE |
> > --
> > 2.19.0.271.gfe8321ec05