[virt-tools-list] [PATCH v2 11/16] session: do not take VTE display into account for geometry changes

[Marc-André Lureau]

Hi

On Thu, Dec 20, 2018 at 8:51 PM Victor Toso <victortoso at redhat.com> wrote:
>
> Hi,
>
> On Wed, Sep 26, 2018 at 07:26:34PM +0400, marcandre.lureau at redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau at redhat.com>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
> > ---
> >  src/virt-viewer-session.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/src/virt-viewer-session.c b/src/virt-viewer-session.c
> > index cd1f037..a40b0bb 100644
> > --- a/src/virt-viewer-session.c
> > +++ b/src/virt-viewer-session.c
> > @@ -29,6 +29,7 @@
> >
> >  #include "virt-viewer-session.h"
> >  #include "virt-viewer-util.h"
> > +#include "virt-viewer-display-vte.h"
> >
> >  #define VIRT_VIEWER_SESSION_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE((o), VIRT_VIEWER_TYPE_SESSION, VirtViewerSessionPrivate))
> >
> > @@ -417,6 +418,10 @@ virt_viewer_session_on_monitor_geometry_changed(VirtViewerSession* self,
> >
> >      for (l = self->priv->displays; l; l = l->next) {
> >          VirtViewerDisplay *d = VIRT_VIEWER_DISPLAY(l->data);
> > +
> > +        if (VIRT_VIEWER_IS_DISPLAY_VTE(d))
> > +            continue;
> > +
>
> I was thinking about this while seeing 07/16, are both necessary?
> Seems that this one is better than 06 and 07 as
> virt_viewer_display_get_preferred_monitor_geometry is only called
> here.

I don't remember well, but it looks like you might be right, this
patch alone could have been enough.

Nevertheless, as you acked, 6 & 7 are still valid, as they may fix
some initialization races, when the display don't yet have window
associated.

thanks

>
> >          guint nth = 0;
> >          GdkRectangle *rect = g_new0(GdkRectangle, 1);
> >
> > --
> > 2.19.0.271.gfe8321ec05
> >