[virt-tools-list] [PATCH v2 0/6] some scsi improvement and bugfixes

[Cole Robinson]

Thanks, I've pushed these patches now with only a minor label spacing
fix in patch 4. Sorry for the massive review delay :/

- Cole

On 11/23/2017 04:32 AM, Lin Ma wrote:
> v1 -> v2:
> * Remove some patches from the original patches:
>     Remove #2, #5, #6 due to they were merged.
>     Remove #4 because the fix is completely wrong, maintainer posted a correct fix.
>     Remove #7, Because lots of changes there, I'd like to follow up it in another patch set later.
> 
> * Rename variable 'dev' to 'controller' in refresh_controller_page for more correctly identifies controllers.
> 
> * Split #1 and #3 into multiple patches for review easier and better code layout.
>     add generic function compare_controller in VirtualDeviceAddress.
>     add generic function pretty_desc in VirtualDeviceAddress to format device addrstr.
>     split details ui into a new patch because it's generic code, will be used for other devices, not only for scsi.
> 
> 
> 
> Lin Ma (6):
>   virtinst: Add a compare_controller function for future use
>   virtinst: Add pretty_desc function for device address printing
>   details: Rename the variable 'dev' to 'controller' in
>     refresh_controller_page
>   ui: details: Add ui for showing attached controller devices in the
>     future
>   details: Disallow removing the scsi controller if disks attached to it
>   details: Show attached disk information in scsi controller page
> 
>  ui/details.ui          | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  virtManager/details.py | 43 ++++++++++++++++++++++++++++++++++---------
>  virtinst/device.py     | 13 +++++++++++++
>  3 files changed, 95 insertions(+), 9 deletions(-)
>