[virt-tools-list] [virt-manager PATCH] vnc: don't skip authentication for listen type none with fixed QEMU

[Pavel Hrdina]

This was fixed by commit <fa03cb7fd21> in QEMU.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1445239

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---

Pushed under trivial rule.

 virtManager/domain.py | 6 +++---
 virtinst/support.py   | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/virtManager/domain.py b/virtManager/domain.py
index 183a56c1..1134a43a 100644
--- a/virtManager/domain.py
+++ b/virtManager/domain.py
@@ -1198,11 +1198,11 @@ class vmmDomain(vmmLibvirtObject):
         flags = 0
 
         # Ugly workaround for VNC bug where the display cannot be opened
-        # if the listen type is "none".  When this gets fixed in QEMU
-        # we should skip auth only for broken QEMUs.
+        # if the listen type is "none".  This bug was fixed in QEMU-2.9.0.
         graphics = self.get_graphics_devices()[0]
         if (graphics.type == "vnc" and
-            graphics.get_first_listen_type() == "none"):
+                graphics.get_first_listen_type() == "none" and
+                not self.conn.SUPPORT_CONN_VNC_NONE_AUTH):
             flags = libvirt.VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH
 
         return self._backend.openGraphicsFD(0, flags)
diff --git a/virtinst/support.py b/virtinst/support.py
index 115c9b15..c27dd50e 100644
--- a/virtinst/support.py
+++ b/virtinst/support.py
@@ -325,6 +325,7 @@ SUPPORT_CONN_RNG_URANDOM = _make(version="1.3.4")
 SUPPORT_CONN_USB3_PORTS = _make(version="1.3.5")
 SUPPORT_CONN_MACHVIRT_PCI_DEFAULT = _make(version="3.0.0")
 SUPPORT_CONN_QEMU_XHCI = _make(version="3.3.0")
+SUPPORT_CONN_VNC_NONE_AUTH = _make(hv_version={"qemu": "2.9.0"})
 
 
 # This is for disk <driver name=qemu>. xen supports this, but it's
-- 
2.14.3