[virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

Cole Robinson crobinso at redhat.com
Mon Jun 11 15:54:56 UTC 2018


On 06/08/2018 05:42 PM, Stefan Berger wrote:
> Show the TPM device model and allow updating it. If a TPM 1.2 has been
> chosen, we only allow the TIS interface to be selected. In case of a
> TPM 2.0 we also enable the choice of the CRB interface.
> 

Patches look good, thanks. One question here though: is this something
we actually expect end users to change for an existing VM? What's the
usecase, besides testing for virt stack developers? I'm trying to be
more discerning of the types of things we allow tweaking in the details
page since it can turn into a bit of a slippery slope, requires more UI
testing and maintenance, etc

Thanks,
Cole




More information about the virt-tools-list mailing list