[virt-tools-list] [virt-manager] [PATCH 3/4] ui: details: Add ui for showing the state of channel in next patch

Cole Robinson crobinso at redhat.com
Tue Jun 26 21:38:59 UTC 2018


On 06/24/2018 11:46 PM, Lin Ma wrote:
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  ui/details.ui          | 25 +++++++++++++++++++++++++
>  virtManager/details.py |  1 +
>  2 files changed, 26 insertions(+)
> 
> diff --git a/ui/details.ui b/ui/details.ui
> index 3018354b..13b71aeb 100644
> --- a/ui/details.ui
> +++ b/ui/details.ui
> @@ -4438,6 +4438,19 @@
>                                              <property name="top_attach">5</property>
>                                            </packing>
>                                          </child>
> +                                        <child>
> +                                          <object class="GtkLabel" id="char-target-state">
> +                                            <property name="visible">True</property>
> +                                            <property name="can_focus">False</property>
> +                                            <property name="halign">start</property>
> +                                            <property name="label" translatable="yes">label507</property>
> +                                            <property name="selectable">True</property>
> +                                          </object>
> +                                          <packing>
> +                                            <property name="left_attach">1</property>
> +                                            <property name="top_attach">6</property>
> +                                          </packing>
> +                                        </child>
>                                          <child>
>                                            <object class="GtkLabel" id="char-source-host">
>                                              <property name="visible">True</property>
> @@ -4498,6 +4511,18 @@
>                                              <property name="top_attach">5</property>
>                                            </packing>
>                                          </child>
> +                                        <child>
> +                                          <object class="GtkLabel" id="char-target-state-label">
> +                                            <property name="visible">True</property>
> +                                            <property name="can_focus">False</property>
> +                                            <property name="halign">end</property>
> +                                            <property name="label" translatable="yes">State:</property>
> +                                          </object>
> +                                          <packing>
> +                                            <property name="left_attach">0</property>
> +                                            <property name="top_attach">6</property>
> +                                          </packing>
> +                                        </child>
>                                          <child>
>                                            <object class="GtkLabel" id="char-source-path-label">
>                                              <property name="visible">True</property>
> diff --git a/virtManager/details.py b/virtManager/details.py
> index e30517f9..145101c2 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -2941,6 +2941,7 @@ class vmmDetails(vmmGObjectUI):
>          show_ui("source_path")
>          show_ui("target_type")
>          show_ui("target_name")
> +        show_ui("target_state")
>  
>      def refresh_hostdev_page(self):
>          hostdev = self.get_hw_selection(HW_LIST_COL_DEVICE)
> 

I think patch #3 and patch #4 either need to be rearranged or combined.
It's weird having this come before the virtinst changes

Thanks,
Cole




More information about the virt-tools-list mailing list