[virt-tools-list] [virt-viewer 3/4] window: Adjust get_image_format() prototype

Eduardo Lima (Etrunko) etrunko at redhat.com
Thu Jun 28 19:38:14 UTC 2018


Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

On 14/06/18 13:01, Christophe Fergeau wrote:
> This adds an unused parameter, but lets us get rid of this new warning
> with gcc 8:
> 
> virt-viewer-window.c: In function 'get_image_format':
> virt-viewer-window.c:930:33: warning: cast between incompatible function types from 'GHashTable * (*)(void)' {aka 'struct _GHashTable * (*)(void)'} to 'void * (*)(void *)' [-Wcast-function-type]
>      g_once(&image_formats_once, (GThreadFunc)init_image_formats, NULL);
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  src/virt-viewer-window.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index af3441f..2be230a 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -910,7 +910,7 @@ static void add_if_writable (GdkPixbufFormat *data, GHashTable *formats)
>      }
>  }
>  
> -static GHashTable *init_image_formats(void)
> +static GHashTable *init_image_formats(G_GNUC_UNUSED gpointer user_data)
>  {
>      GHashTable *format_map;
>      GSList *formats = gdk_pixbuf_get_formats();
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list