[virt-tools-list] [virt-manager PATCH 2/2] cli: stop forking into the background

[Daniel P. Berrangé]

On Tue, May 01, 2018 at 09:48:54AM -0400, Cole Robinson wrote:
> On 05/01/2018 09:23 AM, Daniel P. Berrangé wrote:
> > On Tue, May 01, 2018 at 09:05:49AM -0400, Cole Robinson wrote:
> >>
> >> If openssh-askpass is installed, ssh will launch that and ask for the
> >> password. Last I checked it can only be convinced to launch it if we
> >> fork though

Yeah, I've just looked at the SSH code, and it unconditionally tries
to open /dev/tty, and only if that fails will it use the SSH_ASKPASS
program listed in $ENV which is really unhelpful :-(

> > I question whether that is a genuinely useful solution for virt-manager
> > though. I just tested it and to open virt-manager and display a single
> > guest console I am prompted to enter the same password 5 times. For
> > each additional guest I look at I need to enter another 4 passwords.
> > If SPICE features like file sharing, USB sharing and so on are used,
> > it prompts for the password even more times, because of the number of
> > sockets SPICE needs.
> 
> Yeah for spice it's not realistically usable IMO, though I know some
> people have tried due to bug reports over the years. VNC isn't so bad.
> Since we control the console ssh side of things we potentially have more
> options though, like maybe using paramiko, though I don't know its full
> capabilities here so maybe it doesn't give us anything.
> 
> askpass+virt-manager definitely gets some users, at least people who are
> first using the app or trying to connect to a one off server, see a
> google search for 'virt-manager askpass'. It's not a killer feature but
> removing it to facilitate dropping the fork behavior isn't a clear win IMO.

Ok, lets pause on this suggestion for now and I'll think if there's a way
to make the forking less painful to deal with.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|