[virt-tools-list] [virt-manager PATCH 4/5] tests: Add some tests for virt-xml with KVM

[Pavel Hrdina]

On Fri, Nov 09, 2018 at 04:36:39PM +0100, Andrea Bolognani wrote:
> We're mostly interested in how the default bus/model for
> devices are influenced by knowledge about the guest OS, but
> since the whole thing requires to be connected to the QEMU
> driver we might as well create a new category and leave room
> for more QEMU-specific tests being added down the line.
> 
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---

[...]

> diff --git a/tests/clitest.py b/tests/clitest.py
> index 144eac7a..80f38e65 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -954,6 +954,13 @@ c.add_compare("--remove-device --disk /dev/null", "remove-disk-path")
>  c.add_compare("--remove-device --video all", "remove-video-all", check_version="1.3.3")  # check_version=video primary= attribute
>  c.add_compare("--remove-device --host-device 0x04b3:0x4485", "remove-hostdev-name", check_version="1.2.11")  # check_version=video ram output change
>  
> +c = vixml.add_category("add/rm devices (KVM)", "--connect %(URI-KVM)s --print-diff --define")
> +c.add_compare("test --add-device --disk %(EXISTIMG1)s", "kvm-add-disk-default") # Guest OS is not known
> +c.add_compare("test-many-devices --add-device --disk %(EXISTIMG1)s", "kvm-add-disk-os-from-xml") # Guest OS information taken from the guest XML
> +c.add_compare("test-many-devices --add-device --disk %(EXISTIMG1)s --os-variant winme", "kvm-add-disk-os-from-cmdline") # Guest OS information provided on the command line
> +c.add_compare("test --add-device --network default", "kvm-add-network-default") # Guest OS is not known
> +c.add_compare("test-many-devices --add-device --network default", "kvm-add-network-os-from-xml") # Guest OS information taken from the guest XML
> +c.add_compare("test-many-devices --add-device --network default --os-variant winme", "kvm-add-network-os-from-cmdline") # Guest OS information provided on the command line

$ ./setup.py pylint:

running pycodestyle
tests/clitest.py:958: [E261] at least two spaces before inline comment
tests/clitest.py:959: [E261] at least two spaces before inline comment
tests/clitest.py:960: [E261] at least two spaces before inline comment
tests/clitest.py:961: [E261] at least two spaces before inline comment
tests/clitest.py:962: [E261] at least two spaces before inline comment
tests/clitest.py:963: [E261] at least two spaces before inline comment

I can fix that before pushing.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20181112/a62ef086/attachment.sig>