[virt-tools-list] [virt-manager PATCH 3/5] virt-xml: Accept --os-variant option

[Andrea Bolognani]

On Mon, 2018-11-12 at 16:20 +0100, Pavel Hrdina wrote:
> > +=head1 GUEST OS OPTIONS
> > +
> > +=over 4
> > +
> > +=item B<--os-variant> OS_VARIANT
> > +
> > +Optimize the guest configuration for a specific operating system (ex.
> > +'fedora29', 'rhel7', 'win10'). While not required, specifying this
> > +options is HIGHLY RECOMMENDED, as it can greatly increase performance
> > +by specifying virtio among other guest tweaks.
> > +
> > +If the guest has been installed using virt-manager version 2.0.0 or newer,
> > +providing this information should not be necessary, as the OS variant will
> > +have been stored in the guest configuration during installation and virt-xml
> > +will retrieve it from there automatically.
> > +
> > +Use the command "osinfo-query os" to get the list of the accepted OS
> > +variants.
> > +
> > +=back
> 
> How about adding this new section before "XML OPTIONS"?  It would better
> follow virt-install man page where the "GUEST OS SECTION" is before all
> the devices sections.
> 
> Another point is that users might notice that better if it's before
> "XML OPTIONS" where they will probably end reading man page because
> they found what they were looking for.  I know, you should read the
> whole man page but who does that? :)

Sure, that works for me :)

-- 
Andrea Bolognani / Red Hat / Virtualization