[virt-tools-list] [PATCH virt-viewer] Fullscreen displays on wrong monitors in Wayland

Christophe Fergeau cfergeau at redhat.com
Mon Oct 15 08:42:38 UTC 2018


On Fri, Oct 12, 2018 at 02:51:19PM -0500, Jonathon Jongsma wrote:
> In fullscreen mode, we attempt to enable a guest display for each client
> monitor and then place a fullscreen window for each display on the
> appropriate monitor. Previously, we were using gtk_window_move() to move
> the window to the proper monitor, and then calling
> gtk_window_fullscreen() to enter fullscreen mode on that monitor.
> However, under wayland, gtk_window_move() no longer has any effect for
> toplevel windows, so all displays were showing up on top of eachother on
> the same client monitor.
> 
> Fortunately, Gtk+ 3.18 added a new gtk_window_fullscreen_on_monitor()
> API that works on Wayland. In theory this allows us to remove the call
> to gtk_window_move() from the code. But to avoid potentially changing
> behavior on xorg or older systems, I left the existing logic.

Any plans to remove the gtk_window_move() call later on? Or do you think
we should keep it forever? Apart from that,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20181015/49a1f1ca/attachment.sig>


More information about the virt-tools-list mailing list