[virt-tools-list] [virt-manager PATCH] controller: don't set default controller index

Pavel Hrdina phrdina at redhat.com
Tue Dec 3 12:12:22 UTC 2019


On Tue, Dec 03, 2019 at 01:07:17PM +0100, Pavel Hrdina wrote:
> Libvirt is able to figure this out and it will make usage of the CLI
> options more user-friendly.
> 
> For example if users wants to add a new pcie-root-port to existing VM
> they have to figure out the latest controller index and call it like
> this:
> 
>     virt-xml \
>         --add-device \
>         --controller pci,model=pcie-root-port,index=$nextIndex \
>         $VM
> 
> After this change it will be simply:
> 
>     virt-xml \
>         --add-device \
>         --controller pci,model=pcie-root-port \
>         $VM
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  virtinst/devices/controller.py | 9 ---------
>  1 file changed, 9 deletions(-)

SNACK, tests have to be updated as well.  I'll post v2 shortly.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20191203/1e106404/attachment.sig>


More information about the virt-tools-list mailing list