[virt-tools-list] [virt-manager PATCH v2] controller: don't set default controller index

Cole Robinson crobinso at redhat.com
Tue Dec 3 20:59:40 UTC 2019


On 12/3/19 7:16 AM, Pavel Hrdina wrote:
> Libvirt is able to figure this out and it will make usage of the CLI
> options more user-friendly.
> 
> For example if users wants to add a new pcie-root-port to existing VM
> they have to figure out the latest controller index and call it like
> this:
> 
>     virt-xml \
>         --add-device \
>         --controller pci,model=pcie-root-port,index=$nextIndex \
>         $VM
> 
> After this change it will be simply:
> 
>     virt-xml \
>         --add-device \
>         --controller pci,model=pcie-root-port \
>         $VM
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the virt-tools-list mailing list