[virt-tools-list] [vhostmd PATCH 3/3] Change default transport order in vm-dump-metrics.

[Trapp, Michael]

On 18.12.19, 23:02, "Jim Fehlig" <jfehlig at suse.com> wrote:
    On 11/25/19 11:36 AM, Michael Trapp wrote:
    > From: d032747 <michael.trapp at sap.com>
    > 
    >>From a security perspective virtio should be the preferred transport
    > and therefore the default transport order is virtio, disk[, xenstore]
    
    This makes it sound as though we are changing the default transport order, when 
    in fact we are only changing the order in which the transports are checked by 
    the vm-dump-metrics tool.

Of course, there is no transport order at the vhostmd side ... but the disk should be deactivated in the future.
Ideally there should be virtio activated and disk deactivated but this will be not the case as long as there is
any combination of vhostmd/vm-dump-metrics versions installed that requires disk transport.
The changed order at the vm-dump-metrics side fits to a virtio only setup and for this setup it does not report an error.

    > 
    > A more problematic situation is an active vhostmd disk in the qemu config
    > combined with a deactivated disk in the vhostmd config.
    
    This sounds like the admin's self-inflicted wound :-).
Shit happens ... therefore the package is installed/upgrade in several test environments ;-)
    
    > This configuration error would result in missing updates for vm-dump-metrics
    > and a changed default transport order helps to prevent this situation.
    > ---
    Wouldn't dump_metrics() return -1 if "deactivated disk in the vhostmd config"?
It does, but it also reports an error.
    
Regards
Michael