[virt-tools-list] [PATCH virt-viewer v3 3/3] spice: hook into QMP port

[Daniel P. Berrangé]

On Fri, Feb 01, 2019 at 12:06:11PM +0100, Andrea Bolognani wrote:
> On Fri, 2019-02-01 at 10:47 +0000, Daniel P. Berrangé wrote:
> > On Fri, Jan 18, 2019 at 01:12:15PM +0400, marcandre.lureau at redhat.com wrote:
> > > -SPICE_GTK_REQUIRED="0.35"
> > > +SPICE_GTK_REQUIRED="0.36"
> > 
> > This version of spice-gtk doesn't exist in any repositories at this
> > time.  Instead of bumping the version, please make the code use
> > conditional compilation. This patch has currently broken the build
> > on all platforms.
> 
> Not arguing against conditional compilation, but this made me think:
> would it make sense for us to build spice-gtk on the CentOS CI along
> with all other projects?

Spice has their own CI setup, but I think it could still be useful to
build spice-gtk in our CentOS CI so that we can validate that changes
to it don't accidently cause build regressions for virt-viewer.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|