[virt-tools-list] [PATCH virt-manager 00/10] Preparations for an upcoming patch series

Cole Robinson crobinso at redhat.com
Thu Feb 7 22:53:14 UTC 2019


On 2/6/19 4:55 AM, Marc Hartmayer wrote:
> This patch series prepares the code base in that way that we can reuse
> the boot order functionality used in virt-manager in other tools like
> virt-xml. In addition, this allows us to test all the boot order
> functionalities way easier than before.
> 
> Marc Hartmayer (10):
>   Move (find|compare)_device to guest.py
>   domain/guest: Add get_bootable_devices() method
>   domain: Try to avoid self access since we're operating on guest
>   domain: Try to untangle __use_device_boot_order
>   domain: Move use_device_boot_order to guest
>   domain: Move get boot order methods to guest
>   guest: Add get_boot_order method
>   domain: Move set boot order responsibility to guest
>   guest: Don't exclude redirected devices
>   guest: Don't ignore invalid boot_order inputs
> 
>  virtManager/domain.py | 157 +++---------------------------------------
>  virtinst/__init__.py  |   2 +-
>  virtinst/guest.py     | 149 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 160 insertions(+), 148 deletions(-)
> 

Thanks, pushed now. I added a couple follow up patches to make
find_device a Guest method and compare_device a Device method

- Cole




More information about the virt-tools-list mailing list