[virt-tools-list] [virt-install PATCH 3/3] virt-install: Add --unattended support

[Fabiano Fidêncio]

On Thu, Feb 7, 2019 at 11:13 PM Cole Robinson <crobinso at redhat.com> wrote:
>
> On 2/6/19 8:21 AM, Fabiano Fidêncio wrote:
> > This patch introduces the preliminary support for unattended
> > installations using virt-install.
> >
> > The command-line added is something like:
> > --unattended
> > profile="jeos|desktop",user-password="...",admin-password="...",product-key="..."
> >
> > In case no profile is passed, "jeos" is used as the default one.
> > In case no user or admin password is passed, those are going to be
> > automatically generated and printed to the user.
> > The "product-key" argument is needed for Windows(es) installations.
> >
> > The --unattended argument works with:
> > - --cdrom, thus the user can pass a media to be used;
> > - --location, thus the user can pass a tree/media to be used;
> > - with no arguments, then the tree is taken from osinfo-db for that
> > distro;
> >
> > Using --os-variant is required for when using --unattended.
> >
> > There are still a few things missing in this path that will require some
> > more work to be done, as:
> > - Windowses:
> >   - Handle more than one script (usually needed for installing drivers);
> >   - Support a second disk containing drivers;
> > - General:
> >   - Have a proper check and help about which OSes support which kind of
> >   unattended installations;
> >   - Have a proper way to detect the keyboard layout being used by the
> >   user (currently we just guess it by the user's system language);
> >
>
> Thanks for working on this! Will definitely be nice to have this easily
> accessible with virt-install.
>
> Does it work with Fedora? I tried --os-variant fedora28 --unattended but
> it isn't working... osinfo-db doesn't list 'initrd' as an injection
> method. Are there missing osinfo-db patches?

There are some patches in the libosinfo ML that are needed in order to
have it working for all distros we support unattended installation:
https://www.redhat.com/archives/libosinfo/2018-December/msg00162.html

With those patches, everything should just work.

I'll reply to each of your points later Today after digesting them and
playing a bit with the code.

Thanks a lot for the review and for the whole plumbing work done to
support my patch!