[virt-tools-list] [PATCH virt-manager 04/14] support: Add SUPPORT_CONN_DEVICE_BOOT_ORDER

Marc Hartmayer mhartmay at linux.ibm.com
Tue Feb 26 09:56:34 UTC 2019


...and use it in domain.py.

Signed-off-by: Marc Hartmayer <mhartmay at linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
---
 virtManager/domain.py | 3 ++-
 virtinst/support.py   | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/virtManager/domain.py b/virtManager/domain.py
index 324621de9fa4..eef1661b841a 100644
--- a/virtManager/domain.py
+++ b/virtManager/domain.py
@@ -17,6 +17,7 @@ from virtinst import Guest
 from virtinst import util
 from virtinst import DeviceController
 from virtinst import DeviceDisk
+from virtinst import support
 
 from .libvirtobject import vmmLibvirtObject
 from .libvirtenummap import LibvirtEnumMap
@@ -1230,7 +1231,7 @@ class vmmDomain(vmmLibvirtObject):
 
     def can_use_device_boot_order(self):
         # Return 'True' if guest can use new style boot device ordering
-        return self.conn.is_qemu() or self.conn.is_test()
+        return self.conn.check_support(support.SUPPORT_CONN_DEVICE_BOOT_ORDER)
 
     def get_bootable_devices(self):
         # redirdev can also be marked bootable, but it should be rarely
diff --git a/virtinst/support.py b/virtinst/support.py
index 0f0f6104b32d..a6aabc1f5d2d 100644
--- a/virtinst/support.py
+++ b/virtinst/support.py
@@ -266,6 +266,9 @@ SUPPORT_CONN_USB3_PORTS = _make(version="1.3.5")
 SUPPORT_CONN_MACHVIRT_PCI_DEFAULT = _make(version="3.0.0")
 SUPPORT_CONN_QEMU_XHCI = _make(version="3.3.0", hv_version={"qemu": "2.9.0"})
 SUPPORT_CONN_VNC_NONE_AUTH = _make(hv_version={"qemu": "2.9.0"})
+# since 0.4.6... but 0.7.9 is the allowed minimum
+SUPPORT_CONN_DEVICE_BOOT_ORDER = _make(version="0.7.9",
+                                       hv_version={"qemu": 0, "test": 0})
 
 # We choose qemu 2.11.0 as the first version to target for q35 default.
 # That's not really based on anything except reasonably modern at the
-- 
2.17.0




More information about the virt-tools-list mailing list