[virt-tools-list] [PATCH virt-manager 00/14] Various changes

Cole Robinson crobinso at redhat.com
Mon Jan 7 20:44:10 UTC 2019


On 12/18/2018 08:44 AM, Marc Hartmayer wrote:
> Marc Hartmayer (14):
>    xmlapi: refactor node_is_text function
>    test_urls: simplify the sorting
>    cli: register a parser class only once
>    cli: add register classmethod to each parser
>    cli: rename ParseMemdev to ParserMemdev
>    cli: use Python3 conventions: super()
>    cli: don't use monkey patching
>    cli: refactor noset_cb
>    netlist: use NamedTuple for storing a network device
>    domain: os: use decorator syntax for declaring properties
>    domain: convert _change_boot_order to a instance method
>    domain: remove indirection
>    domain: use else/elif since the conditions are mutually exclusive
>    domain: add docstring for _convert_old_boot_order
> 

Sorry for the review delay, and thanks for the patches! I like the 
cli.py changes, the import time stuff was ugly for sure. I've pushed 
this series with the following changes

* Dropped os decorator patch, see my mail
* Adjusted for cli.py for new --vsock option
* Folded _register_parser impl into the register classmethod
* Some minor pylint/pep8 cleanup

Thanks,
Cole




More information about the virt-tools-list mailing list