[virt-tools-list] [PATCH virt-viewer] Add missing G_MODULE_EXPORT to signal handler

Eduardo Lima (Etrunko) etrunko at redhat.com
Fri Jan 18 19:50:49 UTC 2019


On 1/18/19 5:30 PM, Marc-André Lureau wrote:
> On Fri, Jan 18, 2019 at 6:58 PM Eduardo Lima (Etrunko)
> <etrunko at redhat.com> wrote:
>>
>> Fixes the Windows case where the dialog fails to show with the following
>> message:
>>
>> warning: "Could not find signal handler 'virt_viewer_window_menu_change_cd_activate'"
>>
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> 
> ack

There are couple of other places where this is missing as well, I will
send a follow up.

> 
>> ---
>>  src/virt-viewer-window.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
>> index 2be230a..b2f29a3 100644
>> --- a/src/virt-viewer-window.c
>> +++ b/src/virt-viewer-window.c
>> @@ -1131,7 +1131,7 @@ iso_dialog_response(GtkDialog *dialog,
>>  }
>>  #endif
>>
>> -void
>> +G_MODULE_EXPORT void
>>  virt_viewer_window_menu_change_cd_activate(GtkWidget *menu G_GNUC_UNUSED,
>>                                             VirtViewerWindow *self G_GNUC_UNUSED)
>>  {
>> --
>> 2.20.1
>>
>> _______________________________________________
>> virt-tools-list mailing list
>> virt-tools-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/virt-tools-list


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list