[virt-tools-list] [virt-bootstrap][PATCH] Don't allow overwriting of the root partition

Cedric Bosdonnat cbosdonnat at suse.com
Tue Jan 22 09:39:48 UTC 2019


On Fri, 2019-01-04 at 22:56 +0000, Radostin Stoyanov wrote:
> Closes #7
> 
> Reported-by: @loops
> Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
> ---
>  src/virtBootstrap/virt_bootstrap.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/virtBootstrap/virt_bootstrap.py
> b/src/virtBootstrap/virt_bootstrap.py
> index a0b97a2..4bfa95d 100755
> --- a/src/virtBootstrap/virt_bootstrap.py
> +++ b/src/virtBootstrap/virt_bootstrap.py
> @@ -124,6 +124,9 @@ def bootstrap(uri, dest,
> 
>      if not os.path.exists(dest):
>          os.makedirs(dest)
> +    elif os.path.abspath(dest) == "/":  # Don't overwrite root
> +        logger.error("Unpack to root directory is not allowed")
> +        sys.exit(1)
>      elif not os.path.isdir(dest):  # Show error if not directory
>          logger.error("Destination path '%s' is not directory.",
> dest)
>          sys.exit(1)
> --
> 2.20.1
> 

ACK. Thanks for the patch :)
--
Cedric




More information about the virt-tools-list mailing list